fix: temporary change the PORT in Angular server.ts - #7556
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7556 +/- ##
=======================================
Coverage 53.06% 53.07%
=======================================
Files 391 391
Lines 27003 27015 +12
Branches 5571 5579 +8
=======================================
+ Hits 14330 14339 +9
- Misses 11393 11395 +2
- Partials 1280 1281 +1 ☔ View full report in Codecov by Sentry. |
jamesdaniels
approved these changes
Sep 12, 2024
9kubczas4
enabled auto-merge (squash)
September 12, 2024 07:00
tammam-g
pushed a commit
that referenced
this pull request
Sep 13, 2024
pr-Mais
pushed a commit
that referenced
this pull request
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was a following change in main server file template in Angular 17:
to
The guard to call run function was removed. In the result, there is an issue when someone tries to deploy Angular 17+ app with SSR.
The solution fixes: #6651.
Scenarios Tested
Angular 17+:
runcall and SSR is enabled in angular.json - deployment was successful and SSR pages works (without fix SSR pages were failing)Sample Commands