fix the call to loadNuxtConfig by passing empty object - #7376
Conversation
leoortizz
left a comment
leoortizz
left a comment
There was a problem hiding this comment.
LGTM! Please add changelog then we can merge
|
Changelog added @leoortizz 🙌 |
|
@JamieCurnow looks like prettier is failing for the changelog file, can you make sure to run prettier on it? |
|
Sorry about that @leoortizz - all fixed now and master merged back in 👌 |
Thank you 🙏 . We couldn't merge yet and we have a merge conflict now, can you please fix? |
Head branch was pushed to by a user without write access
|
@leoortizz I've just fixed the merge conflict with the changelog again 👌 |
|
@jamesdaniels, this PR isn't being merged because the integration tests are being skipped for some reason, even if I manually run them, any clue of what's missing? |
|
@leoortizz since this commit is coming from a fork, you (or I) need to pull down the branch and push it to this repo—I tend to use the github CLI to perform this operation for convenience. No need to create a new PR, the integration tests will run on that branch and report back to this PR |
3 participants
Description
Fixes #7375 - a recent update of nuxt has prevented deployments as described in the issue. @nuxt/kit used to just spread the single arg passed into loadNuxtConfig() which would have been a string
dir, so this issue hasn't appeared as you can spread a string, even though it would have had no affect on functionality. A recent update actually uses the first arg to this function and expects it to be an object. This PR fixes the type error that was caused by passing a string when an object was expected.Scenarios Tested
I've done a fresh install of nuxt, a
firebase initand afirebase deployall of which now work with this change.Sample Commands