Update dependencies that use protobufjs - #7127
Open
aalej wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Looking into the failing tests |
joehan
approved these changes
May 8, 2024
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
LGTM - firebase-admin/functions are just devDeps, and the only breaking change in pubsub 4.0.0 was dropping node 12 support. This is extremely low risk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7122
Update a couple of dependencies that use protobufjs
"@google-cloud/pubsub": "^3.0.1" -> "^4.0.0"
"firebase-admin": "^11.5.0", -> "^12.1.0"
"firebase-functions": "^4.3.1", -> "^5.0.1"
Ran
npm update protobufjsto update the rest of the dependencies.Scenarios Tested
N/A
Sample Commands
N/A