Use shell:true for Pub/Sub emulator on Windows - #7033
Merged
Conversation
aalej
reviewed
Apr 22, 2024
aalej
approved these changes
Apr 23, 2024
aalej
left a comment
aalej
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Verified the fix on a Windows machine with Node.js v18.20.2
C:\Users\<PATH>\issues-7026>node -v
v18.20.2
C:\Users\ <PATH>\issues-7026>firebase emulators:start
i emulators: Starting emulators: functions, pubsub
! functions: The following emulators are not running, calls to these services from the Functions emulator will affect production: auth, firestore, database, hosting, storage
i pubsub: Pub/Sub Emulator logging to pubsub-debug.log
i ui: Emulator UI logging to ui-debug.log
i functions: Watching "C:\Users\<PATH>\issues-7026\functions" for Cloud Functions...
+ functions: Using node@18 from host.
Serving at port 8582
+ functions: Loaded functions definitions from source: .
┌─────────────────────────────────────────────────────────────┐
│ ✔ All emulators ready! It is now safe to connect your app. │
│ i View Emulator UI at http://127.0.0.1:4000/ │
└─────────────────────────────────────────────────────────────┘
┌───────────┬────────────────┬─────────────────────────────────┐
│ Emulator │ Host:Port │ View in Emulator UI │
├───────────┼────────────────┼─────────────────────────────────┤
│ Functions │ [127.0.0.1:5001](http://127.0.0.1:5001/) │ http://127.0.0.1:4000/functions │
├───────────┼────────────────┼─────────────────────────────────┤
│ Pub/Sub │ [127.0.0.1:8085](http://127.0.0.1:8085/) │ n/a │
└───────────┴────────────────┴─────────────────────────────────┘
Emulator Hub running at [127.0.0.1:4400](http://127.0.0.1:4400/)
Other reserved ports: 4500
Issues? Report them at https://github.com/firebase/firebase-tools/issues and attach the *-debug.log files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7026.
nodejs/node#52554 Release Blog Post causes spawn/spawnSync to error out when executing bat/cmd files directly without the
shell:trueoption.