inlined.sa propagation cleanup - #10871
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the FUNCTION_REGION environment variable to v2 functions to maintain parity with v1 behavior. It also refactors the deployment retry mechanism to use flexible RetryPredicate functions instead of numeric codes, enabling retries on specific 404 errors related to service accounts. Additionally, it introduces automatic cleanup of newly created service accounts on 100% deployment or role assignment failures. The feedback highlights a potential crash in the isServiceAccount404 predicate when calling JSON.stringify(err) on circular error structures, suggesting a safer try-catch fallback to String(err).
inlined
added a commit
that referenced
this pull request
Jul 30, 2026
### Description Updates CHANGELOG.md to reference PR #10871. Refactors isServiceAccount404 in executor.ts to safely extract error text with String(err) fallback inside a try-catch block to prevent circular reference stringification errors. ### Scenarios Tested - Run mocha unit tests - Run npm run format
Fixes service account IAM propagation delays during Cloud Functions creation by adding a pluggable retry policy to executor task runs. Automatically deletes newly created managed service accounts if 100% of function deploys fail for a codebase. Fixes #10859 Fixes #10860 - Run unit tests: npx mocha src/deploy/functions/release/executor.spec.ts src/deploy/functions/release/fabricator.spec.ts src/deploy/functions/release/planner.spec.ts src/deploy/functions/prepare.spec.ts - Verified lint: npm run lint:changed-files N/A
Updates CHANGELOG.md to reference PR #10871. Refactors isServiceAccount404 in executor.ts to safely extract error text with String(err) fallback inside a try-catch block to prevent circular reference stringification errors. - Run mocha unit tests - Run npm run format
…ecutor ### Description Replaces unanchored substring search with word boundary regex checks in isServiceAccount404 to resolve CodeQL alert. ### Scenarios Tested - Run mocha tests - Verified formatting
inlined
force-pushed
the
inlined.sa-propagation-cleanup
branch
from
July 30, 2026 20:36
5636c69 to
c1bf446
Compare
Member
Author
|
Note: The change to GEMINI.md is because it failed to follow the rule. When interrogated it said that's because it interpreted the rule to be about functions, not loops and suggested the change. |
Member
Author
|
Also, ignore the function region stuff; that was a bad diffbase |
wandamora
reviewed
Jul 30, 2026
…ount404 ### Description Concatenates err.message, err.original?.message, err.context?.body?.error?.message, and String(err) in isServiceAccount404 instead of short-circuiting via || to ensure nested error details are inspected. ### Scenarios Tested - Run mocha unit tests
inlined
enabled auto-merge (squash)
July 30, 2026 22:58
ajperel
approved these changes
Jul 30, 2026
tagboola
pushed a commit
that referenced
this pull request
Aug 5, 2026
* fix(functions): retry SA 404s and clean up SA on 100% deployment failure Fixes service account IAM propagation delays during Cloud Functions creation by adding a pluggable retry policy to executor task runs. Automatically deletes newly created managed service accounts if 100% of function deploys fail for a codebase. Fixes #10859 Fixes #10860 - Run unit tests: npx mocha src/deploy/functions/release/executor.spec.ts src/deploy/functions/release/fabricator.spec.ts src/deploy/functions/release/planner.spec.ts src/deploy/functions/prepare.spec.ts - Verified lint: npm run lint:changed-files N/A * fix(functions): address PR review comments for SA propagation retries Updates CHANGELOG.md to reference PR #10871. Refactors isServiceAccount404 in executor.ts to safely extract error text with String(err) fallback inside a try-catch block to prevent circular reference stringification errors. - Run mocha unit tests - Run npm run format * fix(functions): use word boundary regex for gserviceaccount.com in executor ### Description Replaces unanchored substring search with word boundary regex checks in isServiceAccount404 to resolve CodeQL alert. ### Scenarios Tested - Run mocha tests - Verified formatting * style(functions): format long string in executor.spec.ts to satisfy prettier * style(changelog): format CHANGELOG.md with prettier * style(changelog): reset CHANGELOG.md to single PR entry following release * style(changelog): prettier format single entry CHANGELOG.md * fix(functions): concatenate all error message sources in isServiceAccount404 ### Description Concatenates err.message, err.original?.message, err.context?.body?.error?.message, and String(err) in isServiceAccount404 instead of short-circuiting via || to ensure nested error details are inspected. ### Scenarios Tested - Run mocha unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10859 and #10860
To handle race conditions with SA propagation without polluting code everywhere, executor and throttler queue now accept retry predicates. Friendly predicate names are provided. I've opted to not have consts that are used repeatedly because isTransientError seems like a good thing to be able to read at the call site for what is retried.
To handle cleanup we've just extended the logic in fabricator.