feat(auth-emulator): Add mock Passkey (WebAuthn) support - #10636
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces passkey (WebAuthn) support to the Auth emulator, adding endpoints for starting and finalizing passkey enrollment and sign-in, as well as support for deleting passkeys. It includes corresponding API spec updates, schema definitions, state model enhancements, and a comprehensive test suite in passkey.spec.ts. The review feedback suggests improving WebAuthn compatibility by encoding challenges and user IDs with base64url instead of standard base64, and enforcing global uniqueness of credential IDs during enrollment to prevent duplicate registrations.
macastelaz
force-pushed
the
passkey-auth-emulator
branch
from
June 12, 2026 01:29
6e28476 to
852596f
Compare
* feat(auth-emulator): Add mock Passkey (WebAuthn) support * style(auth-emulator): Avoid using 'as any' cast in passkey finalize handlers * fix(auth-emulator): Resolve strict null check errors on blockingFunctions * test(auth-emulator): Add integration tests for passkey (WebAuthn) support * test(auth-emulator): Increase passkey test coverage for edge cases, fallback names, and missing parameters --------- Co-authored-by: Joe Hanley <joehanley@google.com>
macastelaz
force-pushed
the
passkey-auth-emulator
branch
from
June 12, 2026 01:35
852596f to
2e7d6a8
Compare
macastelaz
marked this pull request as ready for review
June 12, 2026 01:43
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
joehan
approved these changes
Jun 12, 2026
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
Format and add a changelog, then this looks good to me
macastelaz
enabled auto-merge (squash)
June 12, 2026 20:53
bkendall
pushed a commit
that referenced
this pull request
Jul 9, 2026
* feat(auth-emulator): Add mock Passkey (WebAuthn) support (#10609) * feat(auth-emulator): Add mock Passkey (WebAuthn) support * style(auth-emulator): Avoid using 'as any' cast in passkey finalize handlers * fix(auth-emulator): Resolve strict null check errors on blockingFunctions * test(auth-emulator): Add integration tests for passkey (WebAuthn) support * test(auth-emulator): Increase passkey test coverage for edge cases, fallback names, and missing parameters --------- Co-authored-by: Joe Hanley <joehanley@google.com> * Address PR review comments * Fix TS conversion error by using assertion function for BlockingFunctionsJwtPayload * Trigger CLA check * Do not allow duplicate credentialIds Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * perf(auth-emulator): optimize duplicate credential checks and sign-in lookups --------- Co-authored-by: Joe Hanley <joehanley@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
bkendall
pushed a commit
that referenced
this pull request
Jul 9, 2026
* feat(auth-emulator): Add mock Passkey (WebAuthn) support (#10609) * feat(auth-emulator): Add mock Passkey (WebAuthn) support * style(auth-emulator): Avoid using 'as any' cast in passkey finalize handlers * fix(auth-emulator): Resolve strict null check errors on blockingFunctions * test(auth-emulator): Add integration tests for passkey (WebAuthn) support * test(auth-emulator): Increase passkey test coverage for edge cases, fallback names, and missing parameters --------- Co-authored-by: Joe Hanley <joehanley@google.com> * Address PR review comments * Fix TS conversion error by using assertion function for BlockingFunctionsJwtPayload * Trigger CLA check * Do not allow duplicate credentialIds Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * perf(auth-emulator): optimize duplicate credential checks and sign-in lookups --------- Co-authored-by: Joe Hanley <joehanley@google.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support to the auth emulator for the passkey API surface. Passkey support is currently in "private preview" on a feature branch of the firebase web auth SDK (https://github.com/firebase/firebase-js-sdk/tree/passkey) and we are working towards a beta release which will involve updating the auth quickstart that in turn relies on the auth emulator.
Scenarios Tested
Using a locally modified quickstart version with passkey support pointing at a locally running auth emulator with these changes (https://screenshot.googleplex.com/3EbEZapL5Ax8o8h.png) I manually verified: