Skip to content

Set requiredProjectBindings in AI Logic services - #10503

Merged
Berlioz merged 6 commits into
mainfrom
vsfan_ailogic_bindings
May 13, 2026
Merged

Set requiredProjectBindings in AI Logic services#10503
Berlioz merged 6 commits into
mainfrom
vsfan_ailogic_bindings

Conversation

@Berlioz

@Berlioz Berlioz commented May 12, 2026

Copy link
Copy Markdown
Contributor

In the prepare phase of function deployment, the CLI calls ensureServiceAgentRoles which checks and upserts all requiredProjectBindings for all Services in the deployed Backend.

Projects containing an AI Logic function must grant the roles/run.invoker binding to the AI Logic service account.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AILogicService class in src/deploy/functions/services/ailogic.ts by adding a requiredProjectBindings method. This method ensures that the Firebase Vertex AI service agent is granted the roles/run.invoker role, allowing the AI logic proxy server to invoke functions. I have no feedback to provide.

@Berlioz
Berlioz requested a review from ajperel May 12, 2026 22:30
Comment thread src/deploy/functions/services/ailogic.ts
Comment thread src/deploy/functions/services/ailogic.ts
@Berlioz
Berlioz merged commit 1a32765 into main May 13, 2026
52 checks passed
@Berlioz
Berlioz deleted the vsfan_ailogic_bindings branch May 13, 2026 18:20
bkendall pushed a commit that referenced this pull request Jul 9, 2026
Co-authored-by: Andy Perelson <ajperel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants