Skip to content

Provide ESM modules from webchannel-wrapper - #7228

Merged
hsubox76 merged 2 commits into
masterfrom
ch-ww-esm
Apr 17, 2023
Merged

Provide ESM modules from webchannel-wrapper#7228
hsubox76 merged 2 commits into
masterfrom
ch-ww-esm

Conversation

@hsubox76

Copy link
Copy Markdown
Contributor

Use emitModulePackageFile plugin to ensure consumers looking for ES modules can get one from the webchannel-wrapper package.

@changeset-bot

changeset-bot Bot commented Apr 14, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f6f286a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot

google-oss-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

@google-oss-bot

google-oss-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

Size Analysis Report 1

Affected Products

No changes between base commit (ecb4454) and merge commit (c0ef6d0).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QUXexwHsmZ.html

@hsubox76
hsubox76 marked this pull request as ready for review April 14, 2023 18:52

@dwyfrequency dwyfrequency left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76
hsubox76 merged commit 5e5c412 into master Apr 17, 2023
@hsubox76
hsubox76 deleted the ch-ww-esm branch April 17, 2023 16:48
@google-oss-bot google-oss-bot mentioned this pull request Apr 25, 2023
@firebase firebase locked and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants