zero image details in FIRCLSBinaryImageFindImageForUUID - #16407
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
3 participants
FIRCLSBinaryImageFillInImageDetails treats vmaddr_slide as an input rather than something it sets: it never assigns the field, but reads it to build node.unwindInfo, node.ehFrame and node.crashInfo, and it only fills uuidString, encrypted and the SDK versions when the matching load commands are present. FIRCLSBinaryImageFindImageForUUID is the only one of the three call sites that passes a stack struct without zeroing it first, so those three pointers come out of a garbage slide value and a UUID match copies them back to the caller. Zero the struct before filling it, the way FIRCLSBinaryImageChanged and FIRCLSBinaryImageRecordMainExecutable already do.