Skip to content

fix(firestore): remove designated initializers for force_index - #16229

Merged
dlarocque merged 3 commits into
mainfrom
dl/forceindex-initializer
Jun 10, 2026
Merged

fix(firestore): remove designated initializers for force_index#16229
dlarocque merged 3 commits into
mainfrom
dl/forceindex-initializer

Conversation

@dlarocque

@dlarocque dlarocque commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Removes use of designated initializers for force_index. These are a C++ 20 feature, and are causing compilation failures on Windows.

Compilation succeeds with Clang since it uses C language extensions which allow designated initializers. The C++ compiler on Windows does not use C language extensions by default.

@gemini-code-assist

gemini-code-assist Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dlarocque dlarocque mentioned this pull request Jun 4, 2026
Closed
@dlarocque
dlarocque requested a review from cherylEnkidu June 4, 2026 16:20
cherylEnkidu
cherylEnkidu approved these changes Jun 5, 2026
View reviewed changes
Comment thread Firestore/CHANGELOG.md
@cherylEnkidu

cherylEnkidu commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for the fix!

@dlarocque
dlarocque merged commit 05a216b into main Jun 10, 2026
75 of 78 checks passed
@dlarocque
dlarocque deleted the dl/forceindex-initializer branch June 10, 2026 14:40
@github-actions github-actions Bot mentioned this pull request Jun 17, 2026
Merged
leojaygoogle pushed a commit that referenced this pull request Jun 29, 2026
@dlarocque @leojaygoogle
fix(firestore): remove designated initializers for force_index (#16229
edd57f2 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

No one assigned

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dlarocque @cherylEnkidu