Skip to content

feat(firestore): add map pipeline expressions - #16015

Merged
dlarocque merged 4 commits into
mainfrom
dl/map
Mar 31, 2026
Merged

feat(firestore): add map pipeline expressions#16015
dlarocque merged 4 commits into
mainfrom
dl/map

Conversation

@dlarocque

Copy link
Copy Markdown
Contributor

Adds support for mapSet, mapKeys, mapValues, mapEntries expressions.

Adds support for `mapSet`, `mapKeys`, `mapValues`, `mapEntries`
expressions.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dlarocque

Copy link
Copy Markdown
Contributor Author

/gemini review

Comment thread Firestore/Swift/Tests/Integration/PipelineTests.swift Outdated

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the mapSet, mapKeys, mapValues, and mapEntries Pipeline expressions, including implementations and integration tests. Feedback identifies a typo in the changelog and a redundant TODO comment in the test file.

Comment thread Firestore/CHANGELOG.md Outdated
Comment thread Firestore/Swift/Tests/Integration/PipelineTests.swift Outdated
dlarocque and others added 3 commits March 31, 2026 11:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dlarocque
dlarocque marked this pull request as ready for review March 31, 2026 16:05

@milaGGL milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlarocque
dlarocque enabled auto-merge (squash) March 31, 2026 17:35
@dlarocque
dlarocque merged commit 95f2fc3 into main Mar 31, 2026
72 of 75 checks passed
@dlarocque
dlarocque deleted the dl/map branch March 31, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants