AuthenticationExample secure password fields - #16000
Conversation
…(login/create account and update password flows) secure and toggleable. This was flagged in a recent demo where the presenter had to use a basic password like '123456' to avoid screensharing a more meaningful password.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a secure password toggle feature across the sample application, including a new SwiftUI SecureToggleField and updates to the UIKit UserViewController to support password visibility toggling. It also updates UI tests to handle secure text fields and "Save Password" prompts. Feedback includes addressing a potential runtime crash on iOS 13 due to UIAction usage, replacing sleep calls in UI tests with more robust waits, and improving accessibility for the toggle buttons.
|
For the satisfying the style check, see https://github.com/firebase/firebase-ios-sdk?tab=readme-ov-file#code-formatting |
- Add accessibility label to LoginView.swift toggle button - Fix UserViewController.swift memory leak and icon inversion - Remove misleading iOS 14+ comment in UserViewController.swift - Reduce UI tests wait timeout to 1.0 and use XCTNSPredicateExpectation Co-authored-by: macastelaz <34776182+macastelaz@users.noreply.github.com>
- Fix AuthenticationExampleUITests.swift spacing to fix `scripts/style.sh` failure - Reduce UI tests wait timeout to 1.0 and use XCTNSPredicateExpectation Co-authored-by: macastelaz <34776182+macastelaz@users.noreply.github.com>
…d bad use of sleep in tests.
- Fix memory leak by weakly capturing UI elements in UIAction - Correct icon toggle logic (`eye` vs `eye.slash`) - Lower UI wait timeouts for performance - Address UI test `sleep` flakes with XCTWaiter - Fix code styling in AuthenticationExampleUITests.swift Co-authored-by: macastelaz <34776182+macastelaz@users.noreply.github.com>
Co-authored-by: macastelaz <34776182+macastelaz@users.noreply.github.com>
- Restore `passwordSheet.waitForExistence(timeout: 3.0)` to prevent flaky XCUITest taps - Keep `XCTWaiter` to explicitly block execution until iOS Save Password prompt disappears - Ensure test element queries use `app.secureTextFields["Password"]` Co-authored-by: macastelaz <34776182+macastelaz@users.noreply.github.com>
2 participants
Update the AuthenticationExample application to make password fields (login/create account and update password flows) secure and toggle-able. This was flagged in a recent demo where the presenter had to use a basic password like '123456' to avoid screen sharing a more meaningful password.