[AI] Add GenerationConfig.merge(_:with:) unit tests - #15918
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…firebase-ios-sdk into ah/ai-generative-model-session # Conflicts: # FirebaseAI/Tests/TestApp/Tests/Integration/GenerativeModelSessionTests.swift
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a good set of unit tests for the GenerationConfig.merge method, covering various scenarios including nil inputs, property merging, and schema precedence. The tests are clear and well-structured. I've added a couple of minor suggestions to make some assertions more specific, which will improve the robustness of the tests.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a comprehensive suite of unit tests for the GenerationConfig.merge(_:with:) method, significantly improving test coverage for this functionality. The new tests cover various scenarios, including nil inputs, property merging, and schema precedence rules. The tests are well-structured and clear. I've provided a couple of minor suggestions to enhance the robustness of two test cases, but overall, this is a solid contribution to the project's test suite.
2 participants
Added unit tests for the
GenerationConfig.merge(_:with:)static method added in #15872 since it only has basic coverage from the the integration tests.#no-changelog