infra: fix Firestore CI cron jobs - #15804
Conversation
- Add explicit Xcode selection (Xcode 16.2) to `spm-source-cron` job to fix CI failure where Xcode version was not set. - Remove `if: github.event_name != 'schedule'` from `changes` job so that dependent jobs like `check` and `pod-lib-lint-cron` can run on scheduled workflows. - Add `xcode: [Xcode_16.4]` to `pod-lib-lint-cron` job matrix as it was missing, which would cause the job to fail when it runs. Co-authored-by: ncooke3 <36927374+ncooke3@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
2 participants
This PR fixes two issues in the
sdk.firestore.ymlworkflow:spm-source-cronjob was failing because it didn't select an Xcode version. I added a step to select Xcode 16.2.pod-lib-lint-cronjob was being skipped on scheduled runs because its dependencycheckdepends onchanges, which was configured to skip on schedules. I removed the skip condition fromchangesto ensure the dependency chain works.xcodematrix variable topod-lib-lint-cronto prevent it from failing once it starts running.PR created automatically by Jules for task 10749625727554048345 started by @ncooke3