fix: Xcode/OS matrices in reusable SPM and CP workflows - #15732
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Fixes a bug that reappeared in this PR where the quickstart script that updates the SPM dependency to point to this PR fails because Github creates a "ghost" commit that does not exist outside of the PR's CI context. This is a problem since the quickstart needs to point to a valid commit on the remote of the Firebase repo. This solution seems to work so far.
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Xcode and OS matrices for reusable CI workflows. The changes involve updating simulator versions and build flags in build.sh to support newer Xcode versions, and improving the logic in scripts/setup_quickstart.sh to correctly obtain the commit SHA for pull requests. A debug log was also removed. The changes are sound and improve the CI setup. I've added one suggestion to make the script that retrieves the commit SHA more robust.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| NSDictionary* testDict = [_userDefaults dictionaryRepresentation]; | ||
| NSLog(@"%@", testDict); | ||
|
|
||
| NSLog(@"foooo"); |
There was a problem hiding this comment.
😆 I'm not sure we want to clean this up. I like it.
|
I removed the I will let the current CI finish and then try moving to Xcode 26.2 to smoke test that version. |
This reverts commit 2669c12.
|
Going to do a follow-up with Xcode 26.2. |
3 participants
Both reusable workflows will test against:
Xcode 16.2 on macOS 15 for iOS only.Contexts:
#no-changelog