Skip to content

bundle_test.cc: Disable LoadBundleWithDocumentsAlreadyPulledFromBackend#972

Closed
dconeybe wants to merge 3 commits intomainfrom
dconeybe/DisableLoadBundleWithDocumentsAlreadyPulledFromBackend
Closed

bundle_test.cc: Disable LoadBundleWithDocumentsAlreadyPulledFromBackend#972
dconeybe wants to merge 3 commits intomainfrom
dconeybe/DisableLoadBundleWithDocumentsAlreadyPulledFromBackend

Conversation

@dconeybe
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe commented May 27, 2022

This test is very flaky, so I'm disabling it for now.

Googlers see b/233751585 for details.

@dconeybe dconeybe added api: firestore skip-release-notes Skip release notes check labels May 27, 2022
@dconeybe dconeybe self-assigned this May 27, 2022
dconeybe added a commit that referenced this pull request May 27, 2022
@dconeybe
cherry-pick bundle_test.cc: Disable LoadBundleWithDocumentsAlreadyPul…
b39452a 
…ledFromBackend (#972)
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 27, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 27, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @dconeybe on commit 4a20e67
Last updated: Fri May 27 09:50 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_target]
[TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2022
@dconeybe
Copy link
Copy Markdown
Contributor Author

dconeybe commented May 28, 2022

This fix was a red herring. The real fix was to fix the JDK version required by the Firestore emulator: the GitHub runners had JDK 8 and JDK 11 was required.

@dconeybe dconeybe closed this May 28, 2022
@dconeybe dconeybe deleted the dconeybe/DisableLoadBundleWithDocumentsAlreadyPulledFromBackend branch May 28, 2022 18:12
dconeybe added a commit that referenced this pull request May 30, 2022
@dconeybe
Revert "cherry-pick bundle_test.cc: Disable LoadBundleWithDocumentsAl…
14b574a 
…readyPulledFromBackend (#972)"

This reverts commit b39452a.
@firebase firebase locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dconeybe dconeybe

Labels

api: firestore skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dconeybe