Skip to content

Support git longpaths#967

Merged
wu-hui merged 11 commits intodconeybe/SnappyPatchRevertfrom
wuandy/WinLongPath
May 27, 2022
Merged

Support git longpaths#967
wu-hui merged 11 commits intodconeybe/SnappyPatchRevertfrom
wuandy/WinLongPath

Conversation

@wu-hui
Copy link
Copy Markdown
Contributor

@wu-hui wu-hui commented May 25, 2022

No description provided.

@wu-hui wu-hui added the tests-requested: quick Trigger a quick set of integration tests. label May 25, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 25, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 25, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @wu-hui on commit 61d6ff9
Last updated: Fri May 27 15:07 PDT 2022
View integration test log & download artifacts

Failures Configs
admob [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
analytics [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
auth [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
database [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
dynamic_links [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
firestore
(6 items)[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [ERROR] [Android] [All 3 os] [1/2 android_device: emulator_target]
[TEST] [ERROR] [iOS] [macos] [1/2 ios_device: simulator_target]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
functions [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
installations [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
messaging [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
remote_config [BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
storage
(4 items)[BUILD] [ERROR] [Linux] [x64] [openssl]
[BUILD] [ERROR] [MacOS] [x64] [openssl]
[BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 25, 2022
@wu-hui wu-hui added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels May 26, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 26, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 26, 2022
@wu-hui wu-hui requested a review from dconeybe May 26, 2022 13:23
@wu-hui
Copy link
Copy Markdown
Contributor Author

wu-hui commented May 26, 2022

Build passed, but there are some test failures and at a glance they seem to be related to the python script you are working on @dconeybe ?

dconeybe
dconeybe reviewed May 26, 2022
View reviewed changes
.github/workflows/android.yml Outdated
git config --global credential.helper 'store --file /tmp/git-credentials'
echo 'https://${{ github.token }}@github.com' > /tmp/git-credentials

- name: Support Longpaths
Copy link
Copy Markdown
Contributor

@dconeybe dconeybe May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultranit: Mention "Git" in the name here, just so it makes more sense when someone sees this out of context.

e.g. "Support Longpaths" -> "Enable Git Longpaths Support"

Copy link
Copy Markdown
Contributor Author

@wu-hui wu-hui May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dconeybe
Copy link
Copy Markdown
Contributor

dconeybe commented May 26, 2022

LGTM. I've merge in the latest changes from the main branch, which may fix the integration tests. Those failures don't look familiar to me, but we can take a look after seeing what happens with the latest changes from main.

@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 26, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 26, 2022
@dconeybe
Copy link
Copy Markdown
Contributor

dconeybe commented May 26, 2022

build-desktop-windows-latest-x64-openssl is indeed failing due to the python virtualenv setup (https://github.com/firebase/firebase-ios-sdk/blob/06185f630e9a3a7594a9ab6b748abaf07bf50466/cmake/python_setup.cmake).

It's weird because, according to the logs, the cmake command is specifying -DFIREBASE_PYTHON_HOST_EXECUTABLE:FILEPATH=C:\hostedtoolcache\windows\Python\3.7.9\x64\python.exe but the FIREBASE_PYTHON_HOST_EXECUTABLE seems to be ignored, and instead it's using the interpreter that is discovered by find_package(Python3 COMPONENTS Interpreter REQUIRED), which is C:/hostedtoolcache/windows/Python/3.10.4/x64/python3.exe. For some reason, on Windows GitHub runners the non-default Python interpreters appear to not support virtualenv.

One guess is that there is a bug/feature in the particular version of cmake being used. I'm going to modify the build to print the cmake version to see if I can reproduce with whatever version is in use.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 26, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 26, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label May 26, 2022
This was referenced May 27, 2022
Merged
Merged
@dconeybe
Copy link
Copy Markdown
Contributor

dconeybe commented May 27, 2022

firebase/firebase-ios-sdk#9851 fixes the problematic usage of designated initialization in value_util.cc noted in the previous comment. I'm going to update this PR to point at the commit with that fix.

@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 27, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels May 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label May 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels May 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2022
@wu-hui wu-hui merged commit 61d6ff9 into dconeybe/SnappyPatchRevert May 27, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels May 27, 2022
@dconeybe dconeybe deleted the wuandy/WinLongPath branch May 27, 2022 18:44
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 27, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 27, 2022
@dconeybe dconeybe mentioned this pull request May 30, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dconeybe dconeybe dconeybe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dconeybe dconeybe

Labels

tests: failed This PR's integration tests failed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wu-hui @dconeybe