Firestore TransactionOptions added, to specify maxAttempts#966
Merged
Firestore TransactionOptions added, to specify maxAttempts#966
Conversation
… PR that adds Snappy support has been merged there
…f the firebase-ios-sdk
…9838, which adds TransactionOptions
…and assignment operator.
…PLE_HARD_ASSERT when given an invalid max_attempts
…tic python_setup.cmake bug
…, which fixes a problematic usage of designated initialization
…operties and settings.gradle
❌ Integration test FAILEDRequested by @dconeybe on commit 252ab6c
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
bot
removed
the
tests: in-progress
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Contributor
Author
|
Everything looks good on desktop and iOS (https://github.com/firebase/firebase-cpp-sdk/actions/runs/2553982778). Need to test Android once this repository's dependency on |
Contributor
Author
|
Android dependencies have now been upgraded: #1007 I've kicked off integration tests to test all platforms, including Android: https://github.com/firebase/firebase-cpp-sdk/runs/7051060951 I've also kicked off the packaging workflow to make sure it won't break anything: https://github.com/firebase/firebase-cpp-sdk/actions/runs/2559321031 |
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
wu-hui
approved these changes
Jun 27, 2022
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of firebase/firebase-ios-sdk#9838 and firebase/firebase-android-sdk#3664, which adds the new
TransactionOptionsclass to Firestore, which can be used to specify the maximum number of attempts to run a transaction before giving up. Previously, this maximum was hardcoded to 5.