Skip to content

Update GitHub Actions to Node.js 24 releases; remove dead custom-runner workflow #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AustinBenoit wants to merge 3 commits into
base: main
Choose a base branch
from
+235 −270
Open

Update GitHub Actions to Node.js 24 releases; remove dead custom-runner workflow #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
058c9b5
Update GitHub Actions to Node.js 24-compatible releases
AustinBenoit Oct 23, 2026
7681865
Remove non-functional update-custom-runner workflow
AustinBenoit Oct 23, 2026
dc44663
integration_tests: skip permission check for bots/schedule, require w…
AustinBenoit Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
matrix_architecture: ${{ steps.export-result.outputs.matrix_architecture }}
matrix_python_version: ${{ steps.export-result.outputs.matrix_python_version }}
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
with:
persist-credentials: true # zizmor: ignore[artipacked]
submodules: false
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
echo "Enabling expanded build and test matrix."
echo "USE_EXPANDED_MATRIX=1" >> $GITHUB_ENV

- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
with:
persist-credentials: true # zizmor: ignore[artipacked]
submodules: true
Expand All @@ -110,18 +110,18 @@ jobs:
MATRIX_ARCHITECTURE: ${{ matrix.architecture }}

- name: Setup python
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4
uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # ratchet:actions/setup-python@v7
with:
python-version: ${{ matrix.python_version }}
architecture: ${{ matrix.architecture }}

- name: Add msbuild to PATH
if: startsWith(matrix.os, 'windows')
uses: microsoft/setup-msbuild@34cfbaee7f672c76950673338facd8a73f637506 # ratchet:microsoft/setup-msbuild@v1.1
uses: microsoft/setup-msbuild@30375c66a4eea26614e0d39710365f22f8b0af57 # ratchet:microsoft/setup-msbuild@v3

- name: Cache NDK
id: cache_ndk
uses: actions/cache@6f8efc29b200d32929f49075959781ed54ec270c # ratchet:actions/cache@v3
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # ratchet:actions/cache@v6
with:
path: /tmp/android-ndk-r23b
key: android-ndk-${{ matrix.os }}-r23b
Expand Down Expand Up @@ -166,7 +166,7 @@ jobs:

- name: Cache ccache files
id: cache_ccache
uses: actions/cache@6f8efc29b200d32929f49075959781ed54ec270c # ratchet:actions/cache@v3
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # ratchet:actions/cache@v6
with:
path: ccache_dir
key: dev-test-ccache-${{ env.MATRIX_UNIQUE_NAME }}
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/build-report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,23 @@ jobs:
if: ${{ matrix.test_set == 'firestore' }}
run: sleep 300
- name: Setup python
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4
uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # ratchet:actions/setup-python@v7
with:
python-version: 3.9
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
with:
persist-credentials: true # zizmor: ignore[artipacked]
fetch-depth: 0
- name: Install Desktop SDK prerequisites
uses: nick-invision/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # ratchet:nick-invision/retry@v2
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # ratchet:nick-fields/retry@v4
with:
timeout_minutes: 15
max_attempts: 3
command: |
python3 scripts/gha/install_prereqs_desktop.py --gha_build
python3 -m pip install requests python-dateutil progress attrs
- name: Fetch GitHub jobs (with retry)
uses: nick-invision/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # ratchet:nick-invision/retry@v2
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # ratchet:nick-fields/retry@v4
with:
timeout_minutes: 20
max_attempts: 3
Expand All @@ -54,7 +54,7 @@ jobs:
fi
python3 scripts/gha/report_build_status.py --token ${{ github.token }} --days ${{ env.numDays }} --write_cache build_status_short.cache ${extra_flags}
- name: Fetch extended GitHub jobs (with retry)
uses: nick-invision/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # ratchet:nick-invision/retry@v2
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # ratchet:nick-fields/retry@v4
with:
timeout_minutes: 80
max_attempts: 3
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
run: |
cat comment.md
- name: Update GitHub issue (with retry)
uses: nick-invision/retry@14672906e672a08bd6eeb15720e9ed3ce869cdd4 # ratchet:nick-invision/retry@v2
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # ratchet:nick-fields/retry@v4
with:
timeout_minutes: 5
max_attempts: 3
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ jobs:
file_format_check:
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
with:
persist-credentials: true # zizmor: ignore[artipacked]
submodules: false
- name: Setup python
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4
uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # ratchet:actions/setup-python@v7
with:
python-version: 3.9
- name: Install prerequisites
Expand Down Expand Up @@ -64,12 +64,12 @@ jobs:
- uses: lukka/get-cmake@591817e96fcad43505fb4eae36172462abb3a42e # ratchet:lukka/get-cmake@latest
with:
cmakeVersion: "~3.31.0"
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
with:
persist-credentials: true # zizmor: ignore[artipacked]
submodules: false
- name: Setup python
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4
uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # ratchet:actions/setup-python@v7
with:
python-version: 3.9
- name: Install prerequisites
Expand Down Expand Up @@ -104,7 +104,7 @@ jobs:
# Check for Google copyright in each file.
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
with:
persist-credentials: true # zizmor: ignore[artipacked]
submodules: false
Expand All @@ -117,7 +117,7 @@ jobs:
# Check that the readme was updated, unless the PR has a specific label set (env.skipReleaseNotesLabel).
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
# Skip this if the PR has the skipReleaseNotes label or if it's a merge to other than main.
if: ${{!contains(github.event.pull_request.labels.*.name, env.skipReleaseNotesLabel) && (github.event.pull_request.base.ref == 'main')}}
with:
Expand Down
22 changes: 14 additions & 8 deletions .github/workflows/checks_secure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Checks (secure)

on:
# This trigger is only safe-ish to use if steps are gated behind the
# action-has-permission check.
# "Check user permission" step below.
# zizmor: ignore[dangerous-triggers]
pull_request_target:
types: [synchronize]
Expand All @@ -22,20 +22,26 @@ jobs:
steps:
- name: Check user permission
id: check
uses: scherermichael-oss/action-has-permission@136e061bfe093832d87f090dd768e14e27a740d3 # ratchet:scherermichael-oss/action-has-permission@1.0.6
# This action sets outputs.has-permission to '1' or ''
with:
required-permission: write
# This step sets outputs.has-permission to '1' or ''
env:
GITHUB_TOKEN: ${{ github.token }}
- uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # ratchet:actions/checkout@v3
GH_TOKEN: ${{ github.token }}
ACTOR: ${{ github.actor }}
run: |
permission=$(gh api "repos/${GITHUB_REPOSITORY}/collaborators/${ACTOR}/permission" --jq '.permission' || echo "none")
echo "User ${ACTOR} has permission: ${permission}"
if [[ "${permission}" == "write" || "${permission}" == "admin" ]]; then
echo "has-permission=1" >> "$GITHUB_OUTPUT"
else
echo "has-permission=" >> "$GITHUB_OUTPUT"
fi
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # ratchet:actions/checkout@v7
if: steps.check.outputs.has-permission != 1 || github.event.pull_request.head.repo.full_name != github.repository
with:
persist-credentials: true # zizmor: ignore[artipacked]
submodules: false
- name: Setup python
if: steps.check.outputs.has-permission != 1 || github.event.pull_request.head.repo.full_name != github.repository
uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4
uses: actions/setup-python@6d4fd22b20465ccc0f7354476588e8df7c9ca0e0 # ratchet:actions/setup-python@v7
with:
python-version: 3.9
- name: Install prerequisites
Expand Down
Loading
Loading