Skip to content

Chore: Remove _LIBCPP_DISABLE_AVAILABILITY build flag - #1909

Merged
AustinBenoit merged 1 commit into
mainfrom
libcpp_fix
Aug 13, 2026
Merged

Chore: Remove _LIBCPP_DISABLE_AVAILABILITY build flag#1909
AustinBenoit merged 1 commit into
mainfrom
libcpp_fix

Conversation

@AustinBenoit

Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Chore: Remove _LIBCPP_DISABLE_AVAILABILITY build flag
This was added in while trying to get some swift code to compile on older ios devices ~iOS 15. The root issue was a missing c++ function on the older devices that has since been added in #1877


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Ran the build locally and test on various ios simulators versions 15.2 and 26.3.1.
Test with the analytics test app as that was the product that needed the symbol.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

Relevant to #1887

@AustinBenoit AustinBenoit added the skip-release-notes Skip release notes check label Aug 12, 2026
@AustinBenoit
AustinBenoit requested a review from a-maurice August 12, 2026 14:05

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the -D_LIBCPP_DISABLE_AVAILABILITY flag from CMAKE_CXX_FLAGS for Apple platforms in CMakeLists.txt. There are no review comments, and I have no feedback to provide.

@AustinBenoit
AustinBenoit merged commit f635682 into main Aug 13, 2026
39 of 55 checks passed
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

❌  Integration test FAILED

Requested by @AustinBenoit on commit f635682
Last updated: Thu Aug 13 15:00 PDT 2026
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FAILURE] [Windows] [x64] [openssl]
(1 failed tests)  ArrayTransformTest.RemoveObjectFromArrayViaUpdate
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseMessagingTest.TestSendMessageToToken

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Aug 13, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants