Update FirestoreCache key type - #1272

Merged

milaGGL merged 24 commits into

mila/MultiDBfrom

mila/MultiDB-update-FirestoreCache-key

May 9, 2023

milaGGL commented Apr 14, 2023 •

edited

Loading

Contributor

Update the FirestoreCache key from App* to std::pair<App*, std::string>, to support multiDB firestore caching.

milaGGL added 5 commits

April 14, 2023 16:38


          debugging the memory error

41a85e1


          change the firestore cache map key type

7a6bbc2


          fill in default database id

7bf521a


          remove std::cout

6c46314


          format

81d607e

milaGGL self-assigned this

milaGGL changed the title ~~debugging the memory error~~ Update FirestoreCache key type

milaGGL added 5 commits

April 18, 2023 15:25


          Update validation_test.cc

258253e


          remove getInstance success check

dba9351


          update test firestore create function

bdf4a1c


          Skip the integration test

59e0710


          format

6433b90

milaGGL marked this pull request as ready for review

April 19, 2023 20:52

milaGGL requested a review from tom-andersen

April 19, 2023 20:52

milaGGL commented

View reviewed changes

firestore/integration_test_internal/src/firestore_test.cc Outdated

milaGGL commented

View reviewed changes

firestore/integration_test_internal/src/firestore_test.cc Outdated

milaGGL commented

View reviewed changes

firestore/integration_test_internal/src/integration_test.cc Outdated

milaGGL commented

View reviewed changes

firestore/src/common/firestore.cc

milaGGL commented

View reviewed changes

firestore/src/common/firestore.cc Outdated

milaGGL added 2 commits

April 20, 2023 12:29


          test firestore terminate() function

51f8bec


          change database_id reference to value

86cced1

milaGGL assigned tom-andersen

tom-andersen reviewed

View reviewed changes

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc Outdated

milaGGL and others added 7 commits

April 25, 2023 15:37


          Apply suggestions from code review

b19d9a6

Co-authored-by: Tom Andersen <tom-andersen@users.noreply.github.com>


          test against emulator

f5370f1


          format

63a7f7c


          enrich integration test cases

4632ea0


          add terminate default db test case

3bde518


          Use test helper to run tests on emulator

d549147


          format

1ca16a1

milaGGL commented

View reviewed changes

firestore/integration_test_internal/src/firestore_integration_test.cc


          add <utility> as required by lint

aad6845

milaGGL commented

View reviewed changes

firestore/integration_test_internal/src/util/integration_test_util.cc

tom-andersen suggested changes

View reviewed changes

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_integration_test.h

firestore/integration_test_internal/src/firestore_test.cc

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/validation_test.cc

firestore/integration_test_internal/src/validation_test.cc

firestore/integration_test_internal/src/validation_test.cc

firestore/src/common/firestore.cc Outdated

firestore/src/common/firestore.cc Outdated


          resolve comments

8ee1871

tom-andersen suggested changes

View reviewed changes

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc

firestore/integration_test_internal/src/validation_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc Outdated

firestore/integration_test_internal/src/firestore_test.cc

milaGGL added 2 commits

May 5, 2023 12:43


          resolve comments

3d7b986


          remove Integration_Test friend from firestore_main.h

d53fbc7

milaGGL commented

View reviewed changes

firestore/integration_test_internal/src/firestore_test.cc Outdated


          remove reset()s

6f7d3ea

milaGGL requested a review from tom-andersen

May 8, 2023 18:52

tom-andersen approved these changes

View reviewed changes

milaGGL merged commit 3c2dc25 into mila/MultiDB

github-actions Bot added the tests: in-progress label

github-actions Bot commented May 9, 2023 •

edited

Loading

❌ Integration test FAILED

Requested by @milaGGL on commit 3c2dc25
Last updated: Tue May 9 10:44 PDT 2023
View integration test log & download artifacts

Failures	Configs
firestore	(6 items) [BUILD] [ERROR] [Android] [All 3 os] [TEST] [ERROR] [Linux] [x64] [openssl] [TEST] [ERROR] [MacOS] [x64] [openssl] [TEST] [ERROR] [iOS] [macos] [All 2 ios_device] [TEST] [ERROR] [tvOS] [macos] [tvos_simulator] [TEST] [FAILURE] [Windows] [x64] [openssl] (3 failed tests) ValidationTest.DifferentFirestoreGetInstanceCanGetSameDefaultFirestoreInstance ValidationTest.DifferentFirestoreGetInstanceWithSameDatabaseNameShouldGetSameFirestoreInstance ValidationTest.FirestoreGetInstanceCalledMultipleTimeReturnSameInstance

Add flaky tests to go/fpl-cpp-flake-tracker

github-actions Bot added the tests: failed label

firebase-workflow-trigger Bot removed the tests: in-progress label

firebase locked and limited conversation to collaborators

a-maurice deleted the mila/MultiDB-update-FirestoreCache-key branch

February 18, 2026 00:14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels