Skip to content

Mila/multi db add get instance header#1267

Merged
milaGGL merged 3 commits intomila/MultiDBfrom
mila/MultiDB-add-getInstance-header
Apr 13, 2023
Merged

Mila/multi db add get instance header#1267
milaGGL merged 3 commits intomila/MultiDBfrom
mila/MultiDB-add-getInstance-header

Conversation

@milaGGL
Copy link
Copy Markdown
Contributor

@milaGGL milaGGL commented Apr 12, 2023

Add 2 overloading methods to the firestore.h file, as proposed in Firestore Multi Database API Proposal:

static Firestore* GetInstance(const char* db_name,
                              InitResult* init_result_out = nullptr);
static Firestore* GetInstance(::firebase::App* app,
                              const char* db_name,
                              InitResult* init_result_out = nullptr);

This is only a definition, actual implementation will be pushed up in following PRs.

@milaGGL milaGGL self-assigned this Apr 12, 2023
@milaGGL milaGGL changed the base branch from main to mila/MultiDB April 12, 2023 23:03
@milaGGL milaGGL added the skip-release-notes Skip release notes check label Apr 12, 2023
@milaGGL milaGGL requested a review from tom-andersen April 12, 2023 23:22
@milaGGL milaGGL merged commit bd7a8df into mila/MultiDB Apr 13, 2023
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 13, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 13, 2023 •
edited
Loading

✅  Integration test succeeded!

Requested by @milaGGL on commit bd7a8df
Last updated: Thu Apr 13 11:27 PDT 2023
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 13, 2023
@firebase firebase locked and limited conversation to collaborators May 14, 2023
@a-maurice a-maurice deleted the mila/MultiDB-add-getInstance-header branch February 18, 2026 00:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tom-andersen tom-andersen tom-andersen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@milaGGL milaGGL

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milaGGL @tom-andersen