Skip to content

Shortened prefix and capped concatenated string - #3728

Merged
rlazo merged 5 commits into
firebase:masterfrom
argzdev:issue_3716_logging
May 17, 2022
Merged

Shortened prefix and capped concatenated string#3728
rlazo merged 5 commits into
firebase:masterfrom
argzdev:issue_3716_logging

Conversation

@argzdev

@argzdev argzdev commented May 16, 2022

Copy link
Copy Markdown
Contributor

Fixes #3716.

Android version 7.0 has a limit of 23 characters when using isLoggable. Since this limit cannot be bypassed or changed, the preferred solution is to shorten the prefix and cap the concatenated string.

The concatenated string with prefix would look like this. Limited at 23 chars.
e.g.

TRuntime.SQLiteEventSto
TRuntime.CctTransportBa
TRuntime.AlarmManagerSc
TRuntime.JobInfoSchedul
TRuntime.Uploader
TRuntime.Executor

@google-oss-bot

google-oss-bot commented May 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Report 1

Affected Products

  • transport-runtime

    Overall coverage changed from 55.08% (269b64b) to 55.19% (b206588) by +0.11%.

    FilenameBase (269b64b)Merge (b206588)Diff
    Logging.java37.93%47.06%+9.13%

Test Logs

Notes

  • Commit (b206588) is created by Prow via merging PR base commit (269b64b) and head commit (48c09aa).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vEnY9XPmH6.html

@google-oss-bot

google-oss-bot commented May 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Size Report 1

Affected Products

  • transport-runtime

    TypeBase (269b64b)Merge (b206588)Diff
    aar178 kB178 kB+348 B (+0.2%)
    apk (aggressive)43.9 kB43.9 kB-8 B (-0.0%)
    apk (release)82.7 kB82.8 kB+112 B (+0.1%)

Test Logs

Notes

  • Commit (b206588) is created by Prow via merging PR base commit (269b64b) and head commit (48c09aa).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xeYbCzS5az.html

@argzdev
argzdev requested a review from rlazo May 16, 2022 10:45
rlazo
rlazo reviewed May 16, 2022
View reviewed changes
Comment thread ...ransport-runtime/src/main/java/com/google/android/datatransport/runtime/logging/Logging.java Outdated
Comment thread ...ransport-runtime/src/main/java/com/google/android/datatransport/runtime/logging/Logging.java Outdated
Comment thread ...ransport-runtime/src/main/java/com/google/android/datatransport/runtime/logging/Logging.java Outdated
rlazo
rlazo reviewed May 16, 2022
View reviewed changes
Comment thread ...ransport-runtime/src/main/java/com/google/android/datatransport/runtime/logging/Logging.java Outdated
Comment thread ...ransport-runtime/src/main/java/com/google/android/datatransport/runtime/logging/Logging.java Outdated
@rlazo

rlazo commented May 17, 2022

Copy link
Copy Markdown
Contributor

/test check-changed

@vkryachko

vkryachko commented May 17, 2022

Copy link
Copy Markdown
Member

Please format the code with ./gradlew :transport:transport-runtime:googleJavaFormat

@argzdev

argzdev commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Got it, thank you!

@rlazo
rlazo merged commit ae6298b into firebase:master May 17, 2022
@argzdev
argzdev deleted the issue_3716_logging branch May 17, 2022 18:01
@firebase firebase locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in datatransport com.google.android.datatransport.runtime.logging.Logging

4 participants

@argzdev @google-oss-bot @rlazo @vkryachko