e2e

avishalom · avishalom · commit 70a3340bb339 · 2018-03-20T01:26:29.000-04:00
diff --git a/firebase_admin/dynamic_links.py b/firebase_admin/dynamic_links.py
@@ -56,7 +56,7 @@ def get_link_stats(short_link, stat_options, app=None):
                     url must start with the protocol "http"
                     stat_options should have a field with duration_days > 0
     """
-    return _get_link_service(app)._get_stats(short_link, stat_options)
+    return _get_link_service(app).get_stats(short_link, stat_options)
 
 def _get_link_service(app):
     """Returns an _LinksService instance for an App.
@@ -193,7 +193,8 @@ def _format_request_string(self, short_link, options):
         #pylint: enable=redundant-keyword-arg
         return self._request_string.format(url_quoted, days)
 
-    def _get_stats(self, short_link, stat_options):
+    def get_stats(self, short_link, stat_options):
+        """Returns the LinkStats of the requested short_link for the duration set in options"""
         if(not isinstance(short_link, six.string_types)
            or not short_link.startswith('https://')):
             raise ValueError('short_link must be a string and begin with "https://".')
diff --git a/integration/test_dynamic_links.py b/integration/test_dynamic_links.py
@@ -26,8 +26,10 @@
 try:
     dynamic_links_e2e_url = testutils.resource('dynamic_links_e2e_url.txt').strip()
 except IOError:
-    sys.stderr.write("End to end tests not set up, see CONTRIBTING.md file.")
+    sys.stderr.write("\nEnd to end tests not set up, see CONTRIBTING.md file.\n")
 
+@pytest.mark.skipif(not dynamic_links_e2e_url,
+                    reason="End to end tests not set up, see CONTRIBTING.md file.")
 class TestEndToEnd(object):
     """Runs an end to end test, see comment string for setup."""
 
