fix: Add transporterOptions when serviceAccountPathOrObject parameter is a object in admin.credential.cert()#2961
Open
FTD-YI wants to merge 1 commit intofirebase:mainfrom
Open
fix: Add transporterOptions when serviceAccountPathOrObject parameter is a object in admin.credential.cert()#2961FTD-YI wants to merge 1 commit intofirebase:mainfrom
FTD-YI wants to merge 1 commit intofirebase:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Please review. |
lahirumaramba
approved these changes
Nov 4, 2025
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you for the contribution! LGTM!
|
We encountered this issue, can this be merged and be included in the next release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
To fix the issue: #2960.
Testing
All tests passed.
API Changes
No Changes.