feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig#2891
Merged
jonathanedey merged 3 commits intofirebase:masterfrom Jun 3, 2025
Merged
feat(fcm): Support apns.live_activity_token field in FCM ApnsConfig#2891jonathanedey merged 3 commits intofirebase:masterfrom
apns.live_activity_token field in FCM ApnsConfig#2891jonathanedey merged 3 commits intofirebase:masterfrom
Conversation
allenkaplan
reviewed
Apr 25, 2025
| }); | ||
| }); | ||
|
|
||
| const invalidApnsLiveActivityTokens: any[] = [null, NaN, 0, 1, true, false] |
There was a problem hiding this comment.
perhaps we should add a test for valid payload?
Contributor
Author
There was a problem hiding this comment.
Sure thing. I added the tests with valid payloads for the live activity start | update | end events
lahirumaramba
previously requested changes
May 12, 2025
* feat(fcm): Support `live_activity_token` field on `ApnsConfig` * added validation * update documentation
janodetzel
force-pushed
the
master
branch
2 times, most recently
from
756c68d to
1d032bd
Compare
jonathanedey
approved these changes
Jun 2, 2025
jonathanedey
assigned
chong-shao,
OrlandriaH-G and
jonathanedey and unassigned
lahirumaramba
OrlandriaH-G
approved these changes
Jun 2, 2025
chong-shao
approved these changes
Jun 3, 2025
jonathanedey
dismissed
lahirumaramba’s stale review
Review requested changes were made and error addressed. Removing to unblock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
live_activity_tokenfield onApnsConfigFixes #2875