Skip to content

Fixes to password policy validation - #2227

Merged
kevinthecheung merged 5 commits into
masterfrom
kc-passwd-policy
Jun 27, 2023
Merged

Fixes to password policy validation#2227
kevinthecheung merged 5 commits into
masterfrom
kc-passwd-policy

Conversation

@kevinthecheung

@kevinthecheung kevinthecheung commented Jun 27, 2023

Copy link
Copy Markdown
Contributor
  • Reorder checks so that you can pass undefined to use defaults
  • Fix some 'undefined' comparisons

@kevinthecheung
kevinthecheung marked this pull request as ready for review June 27, 2023 20:45
pragatimodi and others added 2 commits June 27, 2023 13:49
* Adding TotpInfo to userRecord

* Changing type from `any` to `unknown` for type safety.

* Addressing feedback
@kevinthecheung
kevinthecheung requested review from lahirumaramba and removed request for prameshj June 27, 2023 20:54
@pragatimodi

Copy link
Copy Markdown
Contributor

LGTM, thank you for finding these!

@kevinthecheung
kevinthecheung merged commit 64f0336 into master Jun 27, 2023
@kevinthecheung
kevinthecheung deleted the kc-passwd-policy branch June 27, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants