fix: Export error classes#2151
Merged
lahirumaramba merged 4 commits intofirebase:masterfrom May 8, 2024
Merged
Conversation
|
Would love to see this added, it doesn't appear there's another way to easily access the error types from this package? |
|
I agree this is needed and follows the standard JS pattern for checking for a particular error. Error handling is important to good quality code and this library needs to support that also. @IchordeDionysos this has got out of data with the base branch may need an update |
lahirumaramba
approved these changes
May 8, 2024
Member
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you @IchordeDionysos ! LGTM!
Closed
This was referenced Jun 13, 2024
This was referenced Aug 30, 2024
This was referenced Sep 7, 2024
This was referenced Sep 9, 2024
This was referenced Sep 27, 2024
This was referenced Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
Expose the
FirebaseErrorclasses to enable code like this:Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.