Recaptcha rebase - #2093
Closed
Xiaoshouzi-gh wants to merge 11 commits into
Closed
Conversation
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
* Added integ test for Project Config and Tenants update on reCAPTCHA config
* Support use_account_defender add-on feature for reCAPTCHA config. * Added integration test for account defender feature
- Fix merge conflicts with sms region change - Do not throw exceptions enabling account defender when recaptcha is OFF
Xiaoshouzi-gh
marked this pull request as ready for review
March 3, 2023 01:10
|
Seems CI is failing on the last commit. |
Xiaoshouzi-gh
marked this pull request as draft
March 9, 2023 15:58
Xiaoshouzi-gh
marked this pull request as ready for review
March 9, 2023 17:11
Contributor
Author
|
Duplicate pull request of #2128. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
command for this rebase
recaptcha-rebase-mar is created against the most recent master branch.
git cherry-pick b300093^..d979c1c
resolve conflicts.
Test done
npm run test
npm run test:integration
authEmulator tests done.
manual tests done against project
liubin-dev2.