chore: Increase test coverage for service account impersonation support#2047
Merged
lahirumaramba merged 2 commits intomasterfrom Jan 19, 2023
Merged
chore: Increase test coverage for service account impersonation support#2047lahirumaramba merged 2 commits intomasterfrom
lahirumaramba merged 2 commits intomasterfrom
Conversation
Member
lahirumaramba
commented
Jan 18, 2023
lahirumaramba
commented
- Add more unit tests to cover feat: Fix impersonated service account parsing exception #1862
| .to.throw('Failed to parse impersonated service account file'); | ||
| }); | ||
|
|
||
| it('should throw given an object without a "clientId" pcloneroperty', () => { |
There was a problem hiding this comment.
likely pcloneproperty but I could be wrong
Member
Author
There was a problem hiding this comment.
Good catch! It should be property I will blame it on my cat walking on the keyboard :)
dwyfrequency
approved these changes
Jan 19, 2023
dwyfrequency
left a comment
dwyfrequency
left a comment
There was a problem hiding this comment.
Minor comment on spelling but looks good
lahirumaramba
force-pushed
the
lm-sa-tests
branch
from
bc789f0 to
9148fc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.