Skip to content

Add Firebase auth emulator#510

Merged
ssbushi merged 13 commits intofirebase:add-auth-emulator-supportfrom
7agustibm:master
Feb 11, 2021
Merged

Add Firebase auth emulator#510
ssbushi merged 13 commits intofirebase:add-auth-emulator-supportfrom
7agustibm:master

Conversation

@7agustibm
Copy link
Copy Markdown
Contributor

@google-cla
Copy link
Copy Markdown

google-cla bot commented Jan 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ssbushi ssbushi self-requested a review January 28, 2021 21:45
Copy link
Copy Markdown
Contributor

@ssbushi ssbushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @7agustibm!

Thank you for contributing to this feature request. I've reviewed your code and left a few comments for you to address.

Copy link
Copy Markdown
Contributor

@ssbushi ssbushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @7agustibm,

This looks good. I left a few comments and I can pull this PR once they are addressed. I'll also add one more reviewer before submission.

Thanks a lot!

@ssbushi ssbushi requested a review from yuchenshi February 10, 2021 15:50
@yuchenshi yuchenshi changed the title Add Firestore auth emulator Add Firebase auth emulator Feb 10, 2021
@ssbushi ssbushi self-requested a review February 11, 2021 15:11
@ssbushi ssbushi changed the base branch from master to add-auth-emulator-support February 11, 2021 21:26
@ssbushi ssbushi merged commit 0cb2d60 into firebase:add-auth-emulator-support Feb 11, 2021
ssbushi added a commit that referenced this pull request Apr 16, 2021
* Add Firebase Auth emulator support - UserManager & TenantClient(#510)

* Adds Firebase Auth emulator support for FirebaseUserManager and FirebaseTenantClient classes.
* Adds tests and minor fixes

* Remove new dependency from tests

* Test integrations on CI

* Add unit tests for Auth emulator support

* Lint fixes

* Add more test

* Fix and clean tests

* Address review comments

* Minor fixes

* More review comment changes

* Final fixes

* Fix typo

Co-authored-by: Agustí Becerra Milà <contact@agustibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants