Add Remote Config Parameter Group type #490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
force-pushed
the
lm-rc-param-groups
branch
from
0b9941d to
acafdf8
Compare
hiranya911
suggested changes
Oct 28, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks great. I only had a few nits.
src/test/java/com/google/firebase/remoteconfig/ConditionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/remoteconfig/ParameterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/remoteconfig/TemplateTest.java
Outdated
Show resolved
Hide resolved
hiranya911
approved these changes
Oct 29, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM
Nit: Unit tests use a lot of short variable names like c and p. That's not very Java idiomatic.
Member
Author
Thanks for pointing this out!! Updated with proper variable names! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equals()in all public RC typesequals()when comparing templatesRelated to: #446