Add support for new bandwidthConstrainedOk flag used to deliver notifications to satellite networks#1145
Open
andrew-signal wants to merge 1 commit intofirebase:mainfrom
Open
Conversation
…ications to sat networks
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
Hi! The Android Developers page for Developing for constrained satellite networks indicates that we need to pass a new flag,
bandwidth_constrained_okin our AndroidConfig options, like so, to ensure delivery of our pushes on constrained satellite networks.{ "message":{ "token":"bk3RNwTe3H0:CI2k_HHwgIpoDKCIZvvDMExUdFQ3P1...", "notification":{ "title":"Portugal vs. Denmark", "body":"great match!" } "android": { "bandwidth_constrained_ok": true } } }In order to do this in a server app based on the firebase-admin-java SDK, we need to expose a config option in
AndroidConfigBuilder.(In practice, things seem to be okay without this flag, but the documentation says we should add it, so I'm inclined to add it.)
Testing
direct_boot_ok.mvn testpasses locally on my machine.API Changes
AndroidConfigBuilder, which is the least intrusive change I can make to the public API to expose this now-needed functionality.