fix(fcm): Use Invariant Culture when generating event_time#329
fix(fcm): Use Invariant Culture when generating event_time#329martinwiboe wants to merge 1 commit intofirebase:masterfrom
Conversation
The current implementation uses the local culture to generate the `event_time` timestamp. If the local culture uses a non-US date format, the Firebase service will respond with an error code. This commit changes the implementation to always use the Invariant culture instead.
|
I think this would fix my issue with this exception: FirebaseAdmin.Messaging.FirebaseMessagingException: Invalid value at 'message.android.notification.event_time' (type.googleapis.com/google.protobuf.Timestamp), Field 'event_time', Invalid time format: Failed to parse input |
|
@lahirumaramba sorry if it's not appropriate to tag you directly - but is there anything I need to do for this to be reviewed? The library is currently broken on non-US locales |
|
Hello. I am also blocked by this issue. Is it possible to look at this issue ? InspectlyMads has made a fork with the change as this has not been merged |
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thanks for your patience folks!
Hey @martinwiboe, thanks for your contribution. LGTM! We will get a release out next week with this fix
lahirumaramba
changed the title
|
Moving this to #417 so we can stage test the changes |
4 participants
The current implementation uses the local culture to generate the
event_timetimestamp. If the local culture uses a non-US date format, the Firebase service will respond with an error code. This commit changes the implementation to always use the Invariant culture instead.