Skip to content

change: Update project target frameworks and dependencies#251

Merged
hiranya911 merged 9 commits intofirebase:masterfrom
DenSmoke:upgrade_project
Oct 29, 2020
Merged

change: Update project target frameworks and dependencies#251
hiranya911 merged 9 commits intofirebase:masterfrom
DenSmoke:upgrade_project

Conversation

@DenSmoke
Copy link
Copy Markdown
Contributor

@DenSmoke DenSmoke commented Sep 14, 2020 •
edited by hiranya911
Loading

  • Project target frameworks replaced with .NET Framework 4.6.1 and .NET Standard 2.0 to be consistent with the frameworks supported by other .NET libraries associated with Google Cloud Platform.
  • Removed Google.Api.Gax
  • Updated Google.Api.Gax.Rest to 3.2.0
  • Updated Google.Apis.Auth to 1.49.0
  • Updated System.Collections.Immutable to 1.7.1
  • Fixed tests

API CHANGE: Dropped support for netstandard1.5 and net45 target frameworks. Developers are now required to use netstandard2.0 or net461.
API CHANGE: Upgraded the dependency Google.Api.Gax to the latest major version. Developers that use the PagedAsyncEnumerable interface from this package (usually as the return value of list iteration API calls), may have to update their implementations accordingly.

Resolves #264 #265 #207

@DenSmoke
Copy link
Copy Markdown
Contributor Author

DenSmoke commented Sep 14, 2020

@hiranya911 @lahirumaramba Can someone review please?

@hiranya911
Copy link
Copy Markdown
Contributor

hiranya911 commented Sep 14, 2020

@DenSmoke Thanks for the PR. Really appreciate your effort. This contains several breaking changes. Specifically, following changes are breaking:

  1. Dropping support for netstandard1.5
  2. Upgrading from Gax 2.0 to 3.0

We can look into accepting those changes in the next quarter, and releasing v2 of the SDK. Can I ask you to extract the above 2 changes from here into a separate PR? The remaining changes in this PR (e.g. upgrading test dependencies) can be merged immediately.

@hiranya911 hiranya911 self-requested a review September 14, 2020 18:44
@hiranya911 hiranya911 changed the title Update project target frameworks and dependencies chore: Update project target frameworks and dependencies Sep 14, 2020
@DenSmoke
Copy link
Copy Markdown
Contributor Author

DenSmoke commented Sep 14, 2020

@hiranya911 Upgrading test dependencies is not critical. Main purpose is to solve conflicts like in issue #207 when using GAX 3.0 dependent Google Cloud .NET libraries and Firebase Admin SDK in same .NET project

@hiranya911
Copy link
Copy Markdown
Contributor

hiranya911 commented Sep 14, 2020

Yeah, I understand. We can hold on to this PR for now, and come up with a plan to merge it in the coming months. I just need to sync up with other teams and see if we have any upcoming releases that might potentially conflict with this.

@hiranya911
Copy link
Copy Markdown
Contributor

hiranya911 commented Sep 24, 2020

We have slated this for a release in the next quarter (q4 2020). As a first step we will try to add net461 to the list of target frameworks without any additional changes, and release that. Then we can merge this PR on top of that.

@hiranya911 hiranya911 mentioned this pull request Sep 24, 2020
Merged
@hiranya911
Copy link
Copy Markdown
Contributor

hiranya911 commented Oct 14, 2020

@DenSmoke can I ask you to update this PR and sync up with the latest state of the master branch? We can merge this soon after that.

@DenSmoke
Copy link
Copy Markdown
Contributor Author

DenSmoke commented Oct 14, 2020

@hiranya911 done

hiranya911
hiranya911 approved these changes Oct 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DenSmoke. This LGTM. I'll merge it in a couple of days, and start working on a release.

@hiranya911 hiranya911 changed the title chore: Update project target frameworks and dependencies change: Update project target frameworks and dependencies Oct 15, 2020
@hiranya911 hiranya911 mentioned this pull request Oct 21, 2020
Closed
@hiranya911 hiranya911 merged commit 273ce36 into firebase:master Oct 29, 2020
@DenSmoke DenSmoke deleted the upgrade_project branch February 19, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hiranya911 hiranya911

Labels

api: core release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

conflict between FirebaseAdmin 1.17.1 and Google.Cloud.Firestore 2.2.0

2 participants

@DenSmoke @hiranya911