feat: OAuth Providers (Twitter, GitHub, Microsoft, Yahoo, Apple), Generic OAuth Provider#2255
Merged
demolaf merged 13 commits intofirebase:version-10.0.0-devfrom Oct 24, 2025
Merged
Conversation
- unit tests covering google sign in, anonymous upgrade and error states - updated google auth dependencies
demolaf
changed the title
- flows with scopes/customParameters - apple locale override support for button - providerId, scopes, customParameters, with customizable button (label/icon/color) - update firebase brand auth logo and app icon - translations for sign in with LINE - generic/custom user define oauth example with sign in with discord.
Lyokone
reviewed
Oct 24, 2025
Contributor
Lyokone
left a comment
Lyokone
left a comment
There was a problem hiding this comment.
Logs to be removed but looking good otherwise
Comment on lines
89
to
91
| MICROSOFT("microsoft.com", providerName = "Microsoft"), | ||
| YAHOO("yahoo.com", providerName = "Yahoo"), | ||
| APPLE("apple.com", providerName = "Apple"), |
Contributor
There was a problem hiding this comment.
Are those not considered social provider here?
| // Log.d("GoogleSignIn", "Successfully authorized scopes: ${provider.scopes}") | ||
| } catch (e: Exception) { | ||
| // Log.w("GoogleSignIn", "Failed to authorize scopes: ${provider.scopes}", e) | ||
| // Continue with sign-in even if scope authorization fails |
Contributor
There was a problem hiding this comment.
Let's remove the 3 commented logs here
Comment on lines
179
to
183
| // Log.d( | ||
| // "OAuthSignIn", | ||
| // "Successfully obtained OAuth credential for ${provider.providerName}" | ||
| // ) | ||
| // The user is already signed in via startActivityForSignInWithProvider/startActivityForLinkWithProvider |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P6 - Implement OAuth flows with scopes/customParameters; Apple supports locale.
P7 - Generic handler by providerId, scopes, customParameters, with customizable button (label/icon/color).
sign_in_with_github_and_LINE.webm
sign_in_with_generic_oauth_discord.webm