Fix infinite loop when a Websocket connection is lost - #58
Merged
Merged
Conversation
…hout closing handshake.
fhessel
self-requested a review
November 17, 2019 14:06
Owner
|
Thank you for your contributions, I'll review them as soon as possible. The WebSocket implementation is still quite experimental, so there might be (or probably will be) more issues with it. |
fhessel
approved these changes
Nov 24, 2019
fhessel
left a comment
fhessel
left a comment
Owner
There was a problem hiding this comment.
Could reproduce the problem (using a smartphone and killing the Browser was a good hint) and verify that your suggestion fixes it, so I'd say: Approved!
It might indeed not be an optimal solution to handle the client state in that place, as that is also done at the beginning of the loop() function (here to be precise), but the Websockets in general need some refactoring, so I think that's good for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a client closes a Websocket connection without performing a clean closing hand-shake, the server enters an infinite loop. This happens when the client web-browser is killed. I noticed this behaviour when swiping out Chrome on Android.
The suggested change might not be the best fix possible, but it works.