Implement didNotReceive and bug fixes - #78
Merged
ffMathy merged 5 commits intoFeb 13, 2020
Conversation
Collaborator
Author
|
Also I would sugges two things:
I'm working on another bug fix and a new feature for it, so I'm more than happy to add these stuff if we agree on it! |
Owner
|
Very nice additions! Do all tests pass? |
Collaborator
Author
|
Yes! All 43 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
didNotReceive? #72The issue was that Context.state was being overriden from
SetPropertyStateto aGetPropertyStatewhen callingvoid calculator.mode. So when doing the evaluationcalculator.received(1).mode = trueContext.set was calling theGetPropertyState.setmethod, instead of the expectedSetPropertyState.set. Probably the same issue happens for the reverse (first performing a get, then a set).I updated AVA to latest, and ran npm audit fix. Had to fix a few tests because of the AVA upgrade