59 test commented - #71
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
seems like test was not working in that pr already 92f7e60 |
Owner
|
Is there a way we can make it work though? The PR was merged on purpose despite failing tests, so that I would remember to fix it next time. |
Contributor
Author
|
How about logging WARN instead? There are some complicated typescript stuff like |
Owner
|
That's okay. We'll skip it for now. |
Contributor
Author
|
do you upgrade version in package.json? or smthin
my main question is how it will be published to npm, and how can I download
latest version
ср, 13 нояб. 2019 г. в 15:05, Mathias Lykkegaard Lorenzen <
notifications@github.com>:
… Merged #71
<#71>
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#71?email_source=notifications&email_token=AEO27IJJDMNNHBC2HXYN6YTQTPUPVA5CNFSM4JM2EYZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOU2MKYFA#event-2795023380>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEO27IM7LVMRIWHPD5AKCITQTPUPVANCNFSM4JM2EYZQ>
.
|
Owner
|
It has just been published. https://github.com/ffMathy/FluffySpoon.JavaScript.Testing.Faking/releases |
Contributor
Author
|
oh, yeah i see, thank you 👏
ср, 13 нояб. 2019 г. в 16:01, Mathias Lykkegaard Lorenzen <
notifications@github.com>:
… It has just been published.
https://github.com/ffMathy/FluffySpoon.JavaScript.Testing.Faking/releases
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#71?email_source=notifications&email_token=AEO27IMHUTK5KLLPTWOBCYLQTP3C5A5CNFSM4JM2EYZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED6CBVA#issuecomment-553394388>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEO27IMEVEP6VBZ7IKM4PETQTP3C5ANCNFSM4JM2EYZQ>
.
|
Owner
|
No, thank YOU ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.