allow limited multiple returns - #31
Merged
Merged
Conversation
Owner
|
Keep up the good work! Can we get even closer? |
Karql
added a commit
to Karql/FluffySpoon.JavaScript.Testing.Faking
that referenced
this pull request
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes shortcomings of my previous PR:
Argumentis not used for matching argumentsArgumentis used for every setupArgument, some dont :(It's not clean, but not really worse than before my PRs. Best I could figure out :(
The limitation is because when invoking a method there is no way to tell if user intends to set up return value, I see no reasonable way to work around it without changing API to smth more resembling typemoq...
what do you think @ffMathy ?