Repository navigation
Conversation
Truth129
marked this pull request as ready for review
November 13, 2026 15:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add automatic ROCm (AMD GPU) detection on Linux
Depends on Slicer/light-the-torch#180. Without it, ROCm installs fail because light-the-torch looks for the ROCm dependencies of torch (
triton-rocm,rocm,rocm-sdk-*) on PyPI, which only has placeholder packages with those names.Changes
/sys/class/kfd/kfd/topology/nodes/*/properties). No system ROCm installation is needed, because PyTorch ROCm wheels include or install the ROCm runtime.gfx1201) or "not found".Note: Existing Slicer installs with an older light-the-torch need to uninstall it once so it gets reinstalled from
main.Tested (Slicer 5.13 nightly, Linux, Radeon gfx1201)