Relative adsorption, interfacial enrichment, and interface thickness.#64
Merged
Conversation
…(90-10; just in Python interface, otherwise general) implemented.
g-bauer
requested changes
Oct 19, 2022
prehner
requested changes
Oct 19, 2022
RolfStierle
requested review from
g-bauer and
prehner
and removed request for
g-bauer and
prehner
November 30, 2022 11:12
Contributor
|
Thank you for the revisions! It looks like a nice addition. Can you remove the commented out lines of code? I think without context they are not helpful. Finally please add a changelog entry to the changelog of feos-dft (careful, feos and feos-dft have their own changelogs). |
prehner
approved these changes
Dec 1, 2022
g-bauer
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(90-10; just in Python interface, otherwise general) implemented.