Skip to content

Fix tuple indexing in _density_iteration - #396

Merged
g-bauer merged 2 commits into
mainfrom
fix-density-iteration-tuple
Oct 15, 2026
Merged

g-bauer merged 2 commits into
mainfrom
fix-density-iteration-tuple

Conversation

@g-bauer

@g-bauer g-bauer commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

p_dpdrho returns (a_res, p, dp_drho), but the k = 0 correction read still .0 and .1. This came in with #289

This only affects iterations that start inside the unstable region (dp/dρ < 0). In that case the result can converge to a different root than intended.

@g-bauer
g-bauer merged commit af84e3f into main Oct 15, 2026
18 checks passed
@g-bauer
g-bauer deleted the fix-density-iteration-tuple branch October 15, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants