Skip to content

Fixed transposed jacobian layout in binary association - #386

Merged
g-bauer merged 3 commits into
mainfrom
fix_binary_association
Sep 8, 2026
Merged

g-bauer merged 3 commits into
mainfrom
fix_binary_association

Conversation

@g-bauer

@g-bauer g-bauer commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
  • fixed wrong jacobian layout in binary association (nalgebra is col-major)
  • pressure spinodal: fixed inconsistency with iteration returning density including additional step change, changed order of operations slightly.
  • density iteration: fixed convergence guard (current version always returns Ok() branch)
  • add version for spinodal function for a specified phase with verification of that phase
  • minor: in spinodal, scaled tolerance of derivative by temperature

…stency with iteration returning density including additional step change, fixed convergence guard in density iteration, add version for pressure_spinodal for specified phase.
@g-bauer
g-bauer merged commit 1b956cf into main Sep 8, 2026
18 checks passed
@g-bauer
g-bauer deleted the fix_binary_association branch September 8, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants