Skip to content

Index out of bounds in PhaseDiagram.binary_vle() fixed. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prehner merged 3 commits into from
Jul 3, 2026
+3 −1
Merged

Index out of bounds in PhaseDiagram.binary_vle() fixed. #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a2352c
Index out of bounds in PhaseDiagram.binary_vle() fixed.
Jul 2, 2026
0134b72
Index out of bounds in PhaseDiagram.binary_vle() fixed.
Jul 2, 2026
d5343bc
Merge branch 'main' of github.com:RolfStierle/feos
Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Fixed `PhaseDiagram.binary_vle()` panicking during search for VLLE (tried to access unallocated element). [#361] (https://github.com/feos-org/feos/pull/362)

## [0.9.5] - 2026-04-14
### Added
Expand Down
2 changes: 1 addition & 1 deletion crates/feos-core/src/phase_equilibria/phase_diagram_binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ fn check_for_vlle<E: Residual + Subset, TP: TemperatureOrPressure>(
}
if y[j] < y[i] {
// intersection found!
let (xj, yj, pj) = if j == n - 2 {
let (xj, yj, pj) = if j >= n - 2 {
// Use Henry constant of component 2
let k_inf = (states[n - 1].liquid().ln_phi() - states[n - 1].vapor().ln_phi())
.map(f64::exp)[1];
Expand Down
Loading