Explicit parsing of fields of binary parameters#334
Merged
Conversation
prehner
approved these changes
Jan 22, 2026
… action workflow, moved pyo3 extension feature to pyproject.toml
prehner
pushed a commit
that referenced
this pull request
Jan 25, 2026
* Explicit parsing of fields of binary parameters to provide helpful error messages * Added test for PR-parsing from JSON, added Python binding tests to GH action workflow, moved pyo3 extension feature to pyproject.toml * Added changelog entries * Small modification to changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to flattened deserialization with
serdein conjunction with an optional field insideBinaryRecordthe current main silently transforms parsing errors intoNones. This PR solves this issue by explicitly parsing the record. Our current interfaces on the Python side require the inner model record of a binary parameter to be a struct.