Skip to content

Make members of JobackRecord public #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prehner merged 2 commits into from
Dec 7, 2023
Merged

Make members of JobackRecord public #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd7210
Make members of `JobackRecord` public
prehner Nov 30, 2023
f3a81c6
add changelog entry
prehner Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions feos-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Added `EquationOfState::ideal_gas` to initialize an equation of state that only consists of an ideal gas contribution. [#204](https://github.com/feos-org/feos/pull/204)

### Changed
- Made members of `JobackRecord` public. [#206](https://github.com/feos-org/feos/pull/206)

## [0.5.1] - 2023-11-23
### Fixed
- Aligned how binary segment records are treated in Rust and Python. [#200](https://github.com/feos-org/feos/pull/200)
Expand Down
12 changes: 6 additions & 6 deletions feos-core/src/joback.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ use std::sync::Arc;
/// parametrization for additional molecules in other publications.
#[derive(Serialize, Deserialize, Debug, Clone, Default)]
pub struct JobackRecord {
a: f64,
b: f64,
c: f64,
d: f64,
e: f64,
pub a: f64,
pub b: f64,
pub c: f64,
pub d: f64,
pub e: f64,
}

impl JobackRecord {
Expand Down Expand Up @@ -71,7 +71,7 @@ pub struct JobackParameters {
c: Array1<f64>,
d: Array1<f64>,
e: Array1<f64>,
pure_records: Vec<PureRecord<JobackRecord>>,
pub pure_records: Vec<PureRecord<JobackRecord>>,
}

impl Parameter for JobackParameters {
Expand Down