Add PureRecord and other Python classes to feos.ideal_gas#205
Merged
Conversation
g-bauer
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
Identifier,IdentifierOption,PureRecord, andSegmentRecordtofeos.ideal_gas.In the short term this allows to handle ideal gas parameters like other models. For the future, there remain 3 issues:
PureRecordfor every model, which can lead to confusing errors or the requirement to rename imports.PureRecordinfeos.ideal_gasrefers to Joback specifically, so if we add more models, the naming will be awkward.IdentifierandIdentifierOption) are exported only once.