Skip to content

added derive for EntropyScaling trait for SAFT-VRQ Mie for ResidualModel - #179

Merged
g-bauer merged 3 commits into
mainfrom
saftvrqmie_entropy_scaling
Jul 27, 2023
Merged

g-bauer merged 3 commits into
mainfrom
saftvrqmie_entropy_scaling

Conversation

@g-bauer

@g-bauer g-bauer commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

...and some adjustments for parameter initialization from Python.

@g-bauer
g-bauer requested a review from prehner July 27, 2023 15:02
Comment thread src/pcsaft/python.rs Outdated
/// mu : float, optional
/// Dipole moment in units of Debye.
/// q : float, optional
/// Quadrupole moment in units of Debye.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Quadrupole moment in units of Debye.
/// Quadrupole moment in units of Debye * Angstrom.

@g-bauer
g-bauer merged commit 4f98554 into main Jul 27, 2023
@g-bauer
g-bauer deleted the saftvrqmie_entropy_scaling branch July 27, 2023 16:27
g-bauer added a commit that referenced this pull request Oct 16, 2023
…del (#179)

* added derive for EntropyScaling trait for SAFT-VRQ Mie for ResidualModel

* check for segment number in the record constructor

* fixed docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants