Skip to content

Theory guide: properties#100

Merged
prehner merged 3 commits into
mainfrom
theory_properties
Jan 2, 2023
Merged

Theory guide: properties#100
prehner merged 3 commits into
mainfrom
theory_properties

Conversation

@prehner

@prehner prehner commented Dec 26, 2022

Copy link
Copy Markdown
Contributor

closes #99

@prehner prehner added documentation Improvements or additions to documentation core related to features in feos-core labels Dec 26, 2022
@prehner
prehner requested a review from g-bauer December 26, 2022 16:17

@g-bauer g-bauer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation. Would it be helpful to have details about the implementation (caching, duals) in the theory guide (maybe but not necessarily in this document)?

Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
Comment thread docs/theory/eos/properties.md Outdated
@prehner

prehner commented Dec 27, 2022

Copy link
Copy Markdown
Contributor Author

Great documentation. Would it be helpful to have details about the implementation (caching, duals) in the theory guide (maybe but not necessarily in this document)?

The rust guide already goes into some detail about the implementation of states including, e.g., the cache. Maybe link to it in this document?

@prehner
prehner requested a review from g-bauer December 28, 2022 13:52
@prehner
prehner merged commit 016bb44 into main Jan 2, 2023
@prehner
prehner deleted the theory_properties branch January 2, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core related to features in feos-core documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Theory guide: Properties

2 participants